Fix CI issues #1215
Merged
Fix CI issues #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some investigation, I've reopened PHPLIB-1307 and fixed the issue where |
This syncs index management tests to mongodb/specifications@e54cb7c. This commit also includes a new spec test introduced that should've been copied over in PHPLIB-1307.
Invoking shell scripts using sh instead of relying on the shebang causes problems now that drivers-evergreen-tools assumes bash for most of its scripts.
alcaeus
force-pushed
the
fix-ci
branch
2 times, most recently
from
335e0b8 to
f0c4cc5
Compare
I don't see this change in the PR, but tests are green. |
Upon further investigation, I found that libmongoc is always adding the |
GromNaN
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of a number of test failures:
AuthenticationException, it now throws anEncryptionException. I don't think the exception class matters for the tests (as the spec only suggests checking for failures, not a specific failure), but I can take a closer look at the reason for the change if necessary.This leaves the serverless tests to fail, which I'm investigating as part of PHPLIB-1303.
The patch build for this PR includes the no-aws-creds tasks that currently fail.